search

artefactual-sdps / enduro

A tool to support ingest and automation in digital preservation workflows
https://enduro.readthedocs.io/
Apache License 2.0
4 stars 3 forks source link

Bump Github actions/setup-go from v4 to v5 #876

Closed djjuhasz closed 4 months ago

djjuhasz commented 4 months ago

Fixes a Github actions error:

Node.js 16 actions are deprecated. Please update the following actions
to use Node.js 20: actions/setup-go@v4.
codecov[bot] commented 4 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 47.23%. Comparing base (aff8ee3) to head (4083c0b).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #876 +/- ## ========================================== - Coverage 47.27% 47.23% -0.04% ========================================== Files 94 94 Lines 5087 5087 ========================================== - Hits 2405 2403 -2 - Misses 2461 2462 +1 - Partials 221 222 +1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

djjuhasz commented 4 months ago

What the heck is Codecov complaining about? LGTM

@jraddaoui Codecov's algorithm for diffing changes seems overly strict to me, and I don't know why it thinks code coverage goes down with this commit. :confused:

jraddaoui commented 4 months ago

And it should not look at YAML files, specially those.

djjuhasz commented 4 months ago

@jraddaoui good point, I'll look into adding the .github directory to the Codecov ignored paths.

sevein commented 4 months ago

I think that we have a test or two where the code tested isn't consistently working the same way in all runs. Codecov calls it "indirect changes" and it lists a bunch of potential reasons here: https://docs.codecov.com/docs/unexpected-coverage-changes#reasons-for-indirect-changes. Should be possible to fix.

Update: see https://github.com/artefactual-sdps/enduro/pull/879.