Closed sevein closed 3 months ago
Attention: Patch coverage is 0%
with 5 lines
in your changes are missing coverage. Please review.
Project coverage is 47.21%. Comparing base (
071e45a
) to head (1b77cc3
). Report is 2 commits behind head on main.:exclamation: Current head 1b77cc3 differs from pull request most recent head 3dfca56. Consider uploading reports for the commit 3dfca56 to get more accurate results
Files | Patch % | Lines |
---|---|---|
internal/telemetry/traces.go | 0.00% | 3 Missing :warning: |
internal/api/api.go | 0.00% | 1 Missing :warning: |
main.go | 0.00% | 1 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
I don't know if it's intentional, but it looks like tracing is disabled for "enduro-internal" by default:
2024-03-08T18:45:20.251Z V(0) enduro enduro/main.go:90 Starting... {"version": "0.1.0-t1b77cc376", "pid": 1}
2024-03-08T18:45:20.251Z V(0) enduro enduro/main.go:93 Configuration file loaded. {"path": "/home/enduro/.config/enduro.toml"}
2024-03-08T18:45:20.251Z V(1) enduro enduro/main.go:98 Preservation config {"TaskQueue": "a3m"}
2024-03-08T18:45:20.251Z V(1) enduro telemetry/traces.go:22 Tracing system is disabled. {"enabled": false, "addr": "", "sampling-ration": 1}
2024-03-08T18:45:20.386Z V(0) enduro.temporal-client log/with_logger.go:74 Started Worker {"level": "info", "Namespace": "default", "TaskQueue": "global", "WorkerID": "1@enduro-internal-546894d8df-5sc2s@"}
2024-03-08T18:46:01.957Z V(1) enduro enduro/main.go:294 Starting new workflow {"watcher": "dev-minio", "bucket": "sips", "key": "small.zip", "dir": false}
2024-03-08T18:46:01.971Z V(2) enduro.watcher watcher/minio.go:105 Successfully removed message(s). {"list": "minio-events-failed"}
2024-03-08T18:46:07.443Z V(0) enduro.temporal-client log/with_logger.go:69 NewTimer {"level": "debug", "Namespace": "default", "TaskQueue": "global", "WorkerID": "1@enduro-internal-546894d8df-5sc2s@", "WorkflowType": "storage-upload-workflow", "WorkflowID": "storage-upload-workflow-3e4ddab2-dfec-46cb-a792-18fa6d7137fe", "RunID": "9f2bbf32-222e-4673-9adf-c150e43dd6b8", "Attempt": 1, "TimerID": "5", "Duration": "15m0s"}
2024-03-08T18:46:07.562Z V(0) enduro.temporal-client log/with_logger.go:69 ExecuteActivity {"level": "debug", "Namespace": "default", "TaskQueue": "global", "WorkerID": "1@enduro-internal-546894d8df-5sc2s@", "WorkflowType": "storage-move-workflow", "WorkflowID": "storage-move-workflow-3e4ddab2-dfec-46cb-a792-18fa6d7137fe", "RunID": "f7aebcf6-afaa-4888-9649-07154df8a512", "Attempt": 1, "ActivityID": "6", "ActivityType": "copy-to-permanent-location-activity"}
I've run two transfers through Enduro with this branch:
But I'm not seeing any traces except a few "db-ping" traces :confused:
Oh, I see now - only the API is producing traces
Glad that it's working. I hope it'll get a lot more interesting when start wrapping database connections, HTTP clients, Temporal, service boundaries, etc.
Here's another small chunk of work to enable tracing. There are two changes:
helm template
. With Tilt, you should be able to access Grafana using http://localhost:7490. Log in with usernameadmin
and passwordadmin
.otelhttp
package. This is just a starting point, later we could be adding spans from service methods as needed.How to test:
{resource.service.name="enduro"}
and hitRun query
,