search

artefactual-sdps / enduro

Designed to automate the processing of transfers in multiple Archivematica pipelines.
https://enduro.readthedocs.io/
Apache License 2.0
4 stars 3 forks source link

Fix skip-codecov check in test workflow #884

Closed sevein closed 3 months ago

sevein commented 3 months ago

I added an extra step in test.yml to optionally disable Codecov in commit e5676993. I believed it was working, meaning that Codecov wasn't running, but that was a false positive; the entire job was actually broken. This commit fixes it.

codecov[bot] commented 3 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 47.31%. Comparing base (071e45a) to head (5ecd5da). Report is 5 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #884 +/- ## ========================================== + Coverage 47.27% 47.31% +0.03% ========================================== Files 94 94 Lines 5087 5096 +9 ========================================== + Hits 2405 2411 +6 - Misses 2461 2465 +4 + Partials 221 220 -1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

sevein commented 3 months ago

This seems to be working now - tested with https://github.com/artefactual-sdps/enduro/pull/884/commits/8c53e00a5cae1576d882b1c847bdb14d2dd3c941 (now removed from this branch). The run logs show that the coverage report step is successfully skipped.