artefactual-sdps / enduro

A tool to support ingest and automation in digital preservation workflows
https://enduro.readthedocs.io/
Apache License 2.0
4 stars 3 forks source link

Fix long lines with golines #897

Closed sevein closed 6 months ago

sevein commented 6 months ago

Here's another attempt to fix long lines, this time using golines. This tool does not integrate with golangci-lint but it's also not incompatible either, i.e. golangci-lint is not raising issues with code formatted by golines. The result isn't perfect, but seems good enough. While not integrated with the linter/formatter, I'm considering keeping it installed so we can run it manually for now, or perhaps in CI in the future. Thoughts?

Alternatives:

codecov[bot] commented 6 months ago

Codecov Report

Attention: Patch coverage is 39.38224% with 157 lines in your changes are missing coverage. Please review.

Project coverage is 47.03%. Comparing base (5d3796d) to head (b7f9a16).

:exclamation: Current head b7f9a16 differs from pull request most recent head 2b98c1f. Consider uploading reports for the commit 2b98c1f to get more accurate results

Files Patch % Lines
main.go 0.00% 54 Missing :warning:
cmd/enduro-a3m-worker/main.go 0.00% 44 Missing :warning:
internal/workflow/local_activities.go 0.00% 24 Missing :warning:
internal/package_/preservation_action.go 0.00% 6 Missing :warning:
internal/package_/goa.go 0.00% 5 Missing :warning:
cmd/enduro-am-worker/main.go 0.00% 4 Missing :warning:
internal/a3m/a3m.go 0.00% 3 Missing :warning:
internal/storage/local_activities.go 0.00% 3 Missing :warning:
internal/telemetry/traces.go 0.00% 3 Missing :warning:
internal/workflow/activities/storage.go 0.00% 3 Missing :warning:
... and 8 more
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #897 +/- ## ========================================== - Coverage 47.50% 47.03% -0.47% ========================================== Files 96 96 Lines 5252 5383 +131 ========================================== + Hits 2495 2532 +37 - Misses 2520 2613 +93 - Partials 237 238 +1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.