Closed sevein closed 1 month ago
Attention: Patch coverage is 71.42857%
with 2 lines
in your changes are missing coverage. Please review.
Project coverage is 50.01%. Comparing base (
ac06223
) to head (32f9269
). Report is 3 commits behind head on main.
Files | Patch % | Lines |
---|---|---|
internal/package_/goa.go | 0.00% | 1 Missing :warning: |
internal/storage/download.go | 0.00% | 1 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
We were talking about the bundler yesterday, this will help figure out how it works right now better.
Great, glad to know! I'm not committed to the solution at all and the implemeation has some weirdnesses like the use of the afero library that I wouldn't use today tbh, but since I was passing by and the coverage report was complaining, I decided to add some tests.
This pull request also:
intrange
andcontextcheck
, and