artefactual-sdps / enduro

Designed to automate the processing of transfers in multiple Archivematica pipelines.
https://enduro.readthedocs.io/
Apache License 2.0
4 stars 3 forks source link

Bump golangci-lint from 1.56.2 to 1.58.1 #941

Closed sevein closed 1 month ago

sevein commented 1 month ago

This pull request also:

codecov[bot] commented 1 month ago

Codecov Report

Attention: Patch coverage is 71.42857% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 50.01%. Comparing base (ac06223) to head (32f9269). Report is 3 commits behind head on main.

Files Patch % Lines
internal/package_/goa.go 0.00% 1 Missing :warning:
internal/storage/download.go 0.00% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #941 +/- ## ========================================== + Coverage 48.88% 50.01% +1.12% ========================================== Files 103 102 -1 Lines 5533 5484 -49 ========================================== + Hits 2705 2743 +38 + Misses 2597 2503 -94 - Partials 231 238 +7 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

sevein commented 1 month ago

We were talking about the bundler yesterday, this will help figure out how it works right now better.

Great, glad to know! I'm not committed to the solution at all and the implemeation has some weirdnesses like the use of the afero library that I wouldn't use today tbh, but since I was passing by and the coverage report was complaining, I decided to add some tests.