search

artefactual-sdps / preprocessing-base

Enduro preprocessing child workflow base repository
1 stars 0 forks source link

Add config validation #5

Closed djjuhasz closed 1 month ago

codecov[bot] commented 1 month ago

Codecov Report

Attention: Patch coverage is 88.00000% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 26.54%. Comparing base (e036a3b) to head (e6407c8). Report is 1 commits behind head on main.

Files Patch % Lines
internal/config/config.go 88.00% 3 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #5 +/- ## ========================================== + Coverage 18.24% 26.54% +8.29% ========================================== Files 5 5 Lines 148 162 +14 ========================================== + Hits 27 43 +16 Misses 117 117 + Partials 4 2 -2 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

djjuhasz commented 1 month ago

@jraddaoui discussed the Pros and Cons of using github.com/go-playground/validator for validation and decided the cons outweigh the pros, and we will implement a simpler validation system.