Closed mcantelon closed 3 months ago
Thanks @jraddaoui ! I've addressed most of the feedback, but will fix the rest, add more tests, and add PREMIS event appending from within activities.
@mcantelon I just realized I may not have been clear that passing around io.Reader
, io.Writer
, and *etree.Document
should only be done inside of an activity. We can't return large data structures like *etree.Document
from an activity, so each PREMIS activity should read the existing premis.xml from disk (if it exists) at the beginning of the activity, and write a premis.xml file to disk at the end of the activity.
Thanks @djjuhasz... should be good for another review!
Codecov Report
Attention: Patch coverage is
74.30939%
with93 lines
in your changes missing coverage. Please review.Additional details and impacted files
```diff @@ Coverage Diff @@ ## main #24 +/- ## ========================================== + Coverage 62.79% 66.77% +3.97% ========================================== Files 14 19 +5 Lines 586 936 +350 ========================================== + Hits 368 625 +257 - Misses 198 261 +63 - Partials 20 50 +30 ```:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.