search

artefactual-sdps / preprocessing-sfa

preprocessing-sfa is an Enduro preprocessing workflow for SFA SIPs
1 stars 0 forks source link

Add "verify manifest" activity, fixes #35 #38

Closed djjuhasz closed 3 months ago

codecov[bot] commented 3 months ago

Codecov Report

Attention: Patch coverage is 66.66667% with 37 lines in your changes missing coverage. Please review.

Project coverage is 66.82%. Comparing base (9dc7ee7) to head (83391d1).

Files Patch % Lines
internal/activities/verify_manifest.go 64.00% 9 Missing and 9 partials :warning:
internal/activities/validate_metadata.go 0.00% 7 Missing :warning:
internal/workflow/preprocessing.go 78.78% 6 Missing and 1 partial :warning:
cmd/worker/workercmd/cmd.go 0.00% 4 Missing :warning:
internal/sip/sip.go 93.33% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #38 +/- ## ========================================== - Coverage 66.90% 66.82% -0.09% ========================================== Files 19 20 +1 Lines 973 1061 +88 ========================================== + Hits 651 709 +58 - Misses 267 287 +20 - Partials 55 65 +10 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

djjuhasz commented 3 months ago

@jraddaoui after removing the test SIP and rebasing to get the latest updates from main, I've made quite a few change to the original PR. Can you take another look at the PR please?

djjuhasz commented 3 months ago

@jraddaoui I added a commit to fix the digitized AIP metadata validation — I think I'll keep it as a separate commit when I merge to main.

I also found another bug where the processing workflow wasn't halted when "verify manifest" failed. I've added a third commit to fix this bug, which I'll squash into the first commit before merging.

jraddaoui commented 3 months ago

Good catch, thanks @djjuhasz! I've done the squash and I'll merge to be able to deploy these changes.