search

artefactual-sdps / preprocessing-sfa

preprocessing-sfa is an Enduro preprocessing workflow for SFA SIPs
1 stars 0 forks source link

Add AIS integration PoC #42

Closed jraddaoui closed 3 months ago

jraddaoui commented 3 months ago

Create a new temporal client, worker and workflow to fetch AIP metadata from Archivematica's Storage Service after AIPs are stored, add it to a zipped folder and upload it to a S3/MinIO bucket.

Add a small API server to receive post-store AIP service callbacks from Archivematica's Storage Service and start the AIS workflow.

Run the workers and the API in the same command for now, using github.com/oklog/run to manage goroutines.

codecov[bot] commented 3 months ago

Codecov Report

Attention: Patch coverage is 0.79156% with 376 lines in your changes missing coverage. Please review.

Project coverage is 50.95%. Comparing base (8a78979) to head (9ddc615).

Files Patch % Lines
internal/ais/workflow.go 0.00% 140 Missing :warning:
internal/ais/parse.go 0.00% 68 Missing :warning:
cmd/worker/main.go 0.00% 55 Missing :warning:
internal/ais/amss.go 0.00% 50 Missing :warning:
internal/ais/api.go 0.00% 34 Missing :warning:
internal/ais/fetch.go 0.00% 15 Missing :warning:
cmd/worker/workercmd/cmd.go 0.00% 14 Missing :warning:

:exclamation: There is a different number of reports uploaded between BASE (8a78979) and HEAD (9ddc615). Click for more details.

HEAD has 1 upload less than BASE | Flag | BASE (8a78979) | HEAD (9ddc615) | |------|------|------| ||2|1|
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #42 +/- ## =========================================== - Coverage 67.53% 50.95% -16.59% =========================================== Files 20 25 +5 Lines 1072 1421 +349 =========================================== Hits 724 724 - Misses 285 634 +349 Partials 63 63 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

jraddaoui commented 3 months ago

Thanks @djjuhasz, I'll address those points before merging. Tests will probably come in a different PR, I want to check about possible follow-ups with the team before getting too tied with the implementation, what I mentioned in the issue.