artefactual-sdps / preprocessing-sfa

preprocessing-sfa is an Enduro preprocessing workflow for SFA SIPs
1 stars 0 forks source link

Write file IDs to an identifiers.json file #57

Closed djjuhasz closed 2 months ago

djjuhasz commented 2 months ago

Fixes #53.

djjuhasz commented 2 months ago

Here's what the dashboard record of the "write identifier file" looks like: image

djjuhasz commented 2 months ago

And here's a sample indentifiers.json file (extracted from the downloaded AIP): identifiers.json

codecov[bot] commented 2 months ago

Codecov Report

Attention: Patch coverage is 86.89655% with 19 lines in your changes missing coverage. Please review.

Project coverage is 53.82%. Comparing base (d68086a) to head (96f27d0). Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
internal/workflow/preprocessing.go 63.15% 6 Missing and 1 partial :warning:
cmd/worker/workercmd/cmd.go 0.00% 5 Missing :warning:
internal/activities/write_identifier_file.go 87.87% 2 Missing and 2 partials :warning:
internal/activities/add_premis_objects.go 81.81% 1 Missing and 1 partial :warning:
internal/activities/verify_manifest.go 91.66% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #57 +/- ## ========================================== + Coverage 51.40% 53.82% +2.41% ========================================== Files 27 30 +3 Lines 1564 1687 +123 ========================================== + Hits 804 908 +104 - Misses 696 710 +14 - Partials 64 69 +5 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

djjuhasz commented 2 months ago

I've also confirmed that the SFA file identifiers are present in the METS file: image