search

artefactual-sdps / preprocessing-sfa

preprocessing-sfa is an Enduro preprocessing workflow for SFA SIPs
1 stars 0 forks source link

Fail CI when golines rewraps long lines #76

Closed djjuhasz closed 2 weeks ago

codecov[bot] commented 2 weeks ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 53.90%. Comparing base (a6df444) to head (abf99f5). Report is 2 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #76 +/- ## ======================================= Coverage 53.90% 53.90% ======================================= Files 29 29 Lines 2102 2102 ======================================= Hits 1133 1133 Misses 897 897 Partials 72 72 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

jraddaoui commented 2 weeks ago

Looking at the failed job output, I think the solution in temporal-activities shows a better output, where you can see the actual changes needed. Just a thought, I still find this cleaner.

djjuhasz commented 2 weeks ago

Thanks @jraddaoui. I should have put a WIP tag on this PR. :laughing: I was just trying to test that it actually works and I'm not sure how else to trigger a Github workflow besides creating a PR. I'll check out your suggestions.