artefactual-sdps / preprocessing-sfa

preprocessing-sfa is an Enduro preprocessing workflow for SFA SIPs
1 stars 0 forks source link

Problem: Born Digital AIPs are not being identified correctly #79

Closed sallain closed 3 days ago

sallain commented 2 weeks ago

Describe the bug

The Identify SIP structure activity is currently identifying three types of transfers: BornDigital, DigitizedSIP, and DigitizedAIP. However, there should be four - the two Digitized types as well as BornDigitalSIP and BornDigitalAIP. I think in a previous issue I failed to properly differentiate between the two different types of AIP - apologies. Right now, the activity is identifying all AIPs as DigitizedAIP.

To Reproduce

Steps to reproduce the behavior:

  1. Upload a born digital AIP (e.g. 1-Test-AIP-Files.zip or 2-Test-AIP-GEVER.zip)
  2. Review the output for the task Identify SIP structure - the result will be SIP structure identified: DigitizedAIP

Expected behavior

A born digital SIP should be identified as BornDigitalSIP (this is just a name change to the existing BornDigital). A born digital AIP should be identified as BornDigitalAIP

The criteria for all four types is as follows:

Screenshots

If applicable, add screenshots to help explain your problem.

Additional context

Add any other context about the problem here.

mcantelon commented 5 days ago

PR merged.

sallain commented 3 days ago

LGTM!