search

artefactual-sdps / temporal-activities

Temporal activities is a library of general purpose activities
Apache License 2.0
1 stars 0 forks source link

Relax go version requirement 1.22.3 -> 1.21 #15

Closed djjuhasz closed 6 months ago

djjuhasz commented 6 months ago

See discussion on PR #14.

codecov[bot] commented 6 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 77.20%. Comparing base (01962e2) to head (1df80c0).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #15 +/- ## ======================================= Coverage 77.20% 77.20% ======================================= Files 3 3 Lines 136 136 ======================================= Hits 105 105 Misses 17 17 Partials 14 14 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

djjuhasz commented 6 months ago

I think I'd go with go 1.21 because that accurately represents the needs of this project while maximizing compatibility with all patch versions. As library authors, our primary concern is not to enforce the use of a recent patch version, but to ensure broad compatibility and usability. However, I understand if you disagree, and I'm happy to see how this approach develops over time.

Okay, I'm still conflicted about pushing the responsibility for patching security issues onto the module consumer, but I found at least one Reddit post which supports the strategy of minimizing Go version requirements for libraries, and using the latest patched version for apps, so I will let it go. :shrug: