search

artefactual-sdps / temporal-activities

Temporal activities is a library of general purpose activities
Apache License 2.0
1 stars 0 forks source link

Improve golangci-lint and add golines in CI lint workflow #28

Closed jraddaoui closed 3 months ago

jraddaoui commented 3 months ago

Check individual commits for more info, I separated the changes in four commits to be able to see the failures in CI. I think it's okay to merge like that but let me know if you think squashing them into one is better.

codecov[bot] commented 3 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 85.24%. Comparing base (c40dd94) to head (c5b2918). Report is 1 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #28 +/- ## ======================================= Coverage 85.24% 85.24% ======================================= Files 15 15 Lines 332 332 ======================================= Hits 283 283 Misses 26 26 Partials 23 23 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

djjuhasz commented 3 months ago

@jraddaoui there's just one little typo in the commit message for a9a74c2:

`golangci-lint` doesn't exist with error when it does automatic fixes.

"exist" should be "exit" I think.