artefactual-sdps / temporal-activities

Temporal activities is a library of general purpose activities
Apache License 2.0
1 stars 0 forks source link

Fix xmlvalidate tests #33

Closed djjuhasz closed 1 month ago

djjuhasz commented 1 month ago

Fix the xmlvalidate tests so they don't fail in environments that don't have xmllint installed.

codecov[bot] commented 1 month ago

Codecov Report

Attention: Patch coverage is 84.21053% with 6 lines in your changes missing coverage. Please review.

Project coverage is 81.88%. Comparing base (da08add) to head (2ba4ae0). Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
xmlvalidate/xmllint_validator.go 77.77% 5 Missing and 1 partial :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #33 +/- ## ========================================== - Coverage 82.98% 81.88% -1.11% ========================================== Files 15 16 +1 Lines 429 436 +7 ========================================== + Hits 356 357 +1 - Misses 50 55 +5 - Partials 23 24 +1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

djjuhasz commented 1 month ago

@sevein okay, I'll switch to using an environment variable.