search

artefactual / automation-tools

Tools to aid automation of Archivematica and AtoM.
GNU Affero General Public License v3.0
46 stars 33 forks source link

Issue 690 empty sip UUID #112

Closed ThomasEdvardsen closed 2 years ago

ThomasEdvardsen commented 5 years ago

A first attempt to fix the issue with missing SIP UUID.

Connects to issue #690

ThomasEdvardsen commented 5 years ago

Need some help to correct the Travis Build...

Code is tested and working.

replaceafill commented 5 years ago

Hello @ThomasEdvardsen. My apologies for taking so long to review this for you.

Not sure if you've see the Travis failures yet. We have black set up for linting in the repository and I think in the first error is expecting a shorter line and in the second one is expecting a trailing comma. So changing those lines shown in the Travis output should fix the problem.

Out of curiosity: have you been able to reproduce the issue consistently? I mean, the API not sending the SIP UUID for completed transfers. I've been wanting to determine its root cause.

ThomasEdvardsen commented 5 years ago

Thanks @replaceafill.

Installed Black, and reformatted now :) Is there a guide on how to set up the developer environment any place? I am using IntelliJ.

The problem with the API not sending SIP UUID occurs from time to time.

The root cause is not known for me, but @ross-spencer have updated the docs about this.

ross-spencer commented 5 years ago

Hi @ThomasEdvardsen before I forget, can we ask you to complete this contributor's agreement as we CR and consider merging these changes? I should have mentioned it sooner! Once complete, just email it back to agreement@artefactual.com. For more information please see our CONTRIBUTING.md.

ThomasEdvardsen commented 5 years ago

It was done 15th of May. @sromkey confirmed the agreement and have put it on file.

ThomasEdvardsen commented 5 years ago

Thanks @cole, I will have a look into it when I get a chance.

scollazo commented 5 years ago

@cole what about merging this as is, and create a new pr for your suggestions? I'm being affected by #112 , and this works in my environment.

cole commented 5 years ago

Sure. This PR is an improvement on the current state as is, so I'm ok with merging it as is and deferring any improvements.

replaceafill commented 2 years ago

The underlying issue for this has been fixed in https://github.com/artefactual/archivematica/pull/1795