artefactual / automation-tools

Tools to aid automation of Archivematica and AtoM.
GNU Affero General Public License v3.0
46 stars 33 forks source link

Remove 00_file_to_folder.py pre-transfer hook #37

Closed hakamine closed 5 years ago

hakamine commented 7 years ago

This script causes an intermittent problem of transfers not being approved.

Connected to archivematica/issues#361 Connected to #34

sevein commented 7 years ago

Sorry @hakamine I'm not familiar with that script so I can't tell if this is a good idea or not. Perhaps @jhsimpson is a better person to CR.

hakamine commented 6 years ago

For now, closing without merging. While haven't seen the problem in #34 occur when 00_file_to_folder.py is not used, it may not be the direct culprit, as the problem is not 100% reproducible when using it.

hakamine commented 6 years ago

Reopening this. I added some notes in issue 34, confirmed this script causes the problem of transfers failing to approve . Instead of using this pre-transfer script, we need to ensure that files are inside directories, before executing the automation tools' transfer.py script