Adds AM Client Capability in support of Reingest - Githubissues

artefactual / automation-tools

Tools to aid automation of Archivematica and AtoM.

GNU Affero General Public License v3.0

46 stars 33 forks source link

Adds AM Client Capability in support of Reingest #57

Closed ross-spencer closed 6 years ago

ross-spencer commented 6 years ago

This PR adds capability to AM Client in support of the API functions required for automated reingest.

Adds new functions to AM Client, including reingest and transfer status.
Provides unit testing for the additional function calls.
Extends utils.py request mechanism to enable http authentication headers to be set.
A formatting issue was discovered in models.py while testing which is now corrected.
Warning for non-JSON responses are only output if there is a non-OK HTTP response where responses from the API are not always JSON.

Submitted as part of Redmine ticket 11686 for CCA in support of automated reingest, cc. @timothyryanwalsh.

ross-spencer commented 6 years ago

@sevein @jraddaoui @jrwdunham I have added a second commit to include some additional functions which will help support re-ingest. I'll squash those following review. :+1:

ross-spencer commented 6 years ago

@jrwdunham this is ready for further review I believe. Following our past reviews I've tried to separate a number of commits logically enough for you to see the differences - please let me know if this works okay, or if there is still some improvement i can make in this area. Hope this work is a bit closer to the mark. Thanks again for your help. My work on amclient.py has been useful to learn from.

ross-spencer commented 6 years ago

@sevein @jrwdunham hopefully the submitted commits pull this up to scratch now. I've tried to delineate commits as usefully as possible.

ross-spencer commented 6 years ago

@sevein I have left a comment about the potential tearup method. Otherwise addressed that final syntax issue.

@jrwdunham @sevein it seems I just need explicit approval to squash and merge now. Let me know though if there are any blockers.

ross-spencer commented 6 years ago

@jrwdunham I have squashed my commits and rebased this against master now. From a process perspective I just want to make sure you're happy for me to merge into the master branch at this point?

jrwdunham commented 6 years ago

@ross-spencer I'm just having another look. Sorry I've taken so long. I'll have a response by end of day today.