search

artefactual / automation-tools

Tools to aid automation of Archivematica and AtoM.
GNU Affero General Public License v3.0
46 stars 33 forks source link

Problem: Dataverse pre-transfer hook doesn't have unit tests #65

Closed ross-spencer closed 6 years ago

ross-spencer commented 6 years ago

As a developer I need to be able to understand the current state of legacy branches and their capability. Unit tests help to provide a baseline from which to understand that and then launch the development of new functionality and possible refactoring. Unit tests should be developed for the Dataverse branch to provide that.

The three commits that make up https://github.com/artefactual/automation-tools/pull/15 are:

  1. https://github.com/artefactual/automation-tools/commit/271e1dfcf68528fc4d23b29b9e7359360f290384
  2. https://github.com/artefactual/automation-tools/commit/5af95941f6e293a3830a6fc9bc131191e0accccf
  3. https://github.com/artefactual/automation-tools/commit/89e301e714673bfd548990f8cbbd60420b7354e8
ross-spencer commented 6 years ago

We have started this work here: https://github.com/artefactual/automation-tools/tree/dev/ocul-12127-dataverse-poc

One thing we have noticed is this issue between the Dataverse web-interface and the API: https://github.com/IQSS/dataverse/issues/4715

ross-spencer commented 6 years ago

Closed in favor of: https://github.com/archivematica/Issues/issues/104