artefactual / automation-tools

Tools to aid automation of Archivematica and AtoM.
GNU Affero General Public License v3.0
46 stars 33 forks source link

Problem: Response from hide_units can be non-None even if it fails #67

Closed ross-spencer closed 6 years ago

ross-spencer commented 6 years ago

Here: https://github.com/artefactual/automation-tools/blob/7efd17e3b5345e90c62736842fc42e182b68e8ce/transfers/amclient.py#L185 the response returned from the server via utils.py can be non-None even if there is an issue trying to talk to the server, i.e. we return error codes not None. As such, even in an error scenario a result can be added to the completed_successfully list we then return to the caller.