search

artefactual / automation-tools

Tools to aid automation of Archivematica and AtoM.
GNU Affero General Public License v3.0
46 stars 33 forks source link

Fixes regression involving target name and introduces a new integration test #92

Closed ross-spencer closed 5 years ago

ross-spencer commented 5 years ago

This PR is separated into two commits which will be squished before merging. One to demonstrate the issue reported in the original ticket. The tests will fail. We test for the values we want, not the values we're writing.

The second commit then introduces the correct values to transfer.py so that the tests pass.

archivematica/Issues#447

NB The reason for the additional caution i.e. the two commits is due to the regressions introduced during the previous two commits. This PR is simply a corrective one. In future, if we can refactor this function we should be able to make the automation tools even more robust.

ross-spencer commented 5 years ago

Brilliant thanks @replaceafill I've made those changes - if you want to have another quick look and let me know, I'll rebase and merge.

replaceafill commented 5 years ago

@ross-spencer :+1: