search

artem-ogre / CDT

Constrained Delaunay Triangulation (C++)
https://artem-ogre.github.io/CDT/
Mozilla Public License 2.0
1.08k stars 136 forks source link

Random shuffling not compatible with c++17 #104

Closed petrasvestartas closed 2 years ago

petrasvestartas commented 2 years ago

Hi,

Can you add some checks for the function that use random shuffling dependent on C++ version? The one you use is only compatible till C++14.

artem-ogre commented 2 years ago

Hi, could you elaborate what function do you mean exactly?

here-abarany commented 2 years ago

The last tagged release uses the deprecated (and removed in C++17) std::random_shuffle() function. This was replaced in a later revision (available on master but not in a release tag), though there are still some issues with the shuffling logic as described in #97.

petrasvestartas commented 2 years ago

This part is causing error and I temporarily changed to the following code: image

artem-ogre commented 2 years ago

As @here-abarany mentioned it's fixed on master. I stopped doing releases for CDT (as it's more work) and instead suggest to live on the latest master branch. When I get time, I will make one last release that would say not to use pinned releases to make it clear for the users :)

petrasvestartas commented 2 years ago

Understood, using the git clone instead of release. I close this issue.