search

artem-ogre / CDT

Constrained Delaunay Triangulation (C++)
https://artem-ogre.github.io/CDT/
Mozilla Public License 2.0
1.08k stars 136 forks source link

KDTree namespace conflict #110

Closed proc-sim closed 1 year ago

proc-sim commented 2 years ago

I have a large project I'm testing CDT in, and there happens to be a class in the project named KDTree which causes CDT to generate all kinds of unrelated errors during compilation due to the naming conflict between the KDTree class and CDT's KDTree namespace.

Nesting the KDTree namespace of the CDT library inside the CDT namespace solves the problem. It probably makes sense to have all CDT classes/namespaces nested inside the CDT namespace....KDTree is the only one I see outside of it.

artem-ogre commented 2 years ago

Thank you for opening the issue @tysoni!

Yes, definitely, this is reasonable to do. It sounds like you already made it to work. Would you mind making a PR?

proc-sim commented 2 years ago

Unfortunately I'm pretty limited in my knowledge/usage of github at the moment, so I'm only able to report :)

artem-ogre commented 1 year ago

@tysoni I merged the fix. Please let me know if it worked for you.

proc-sim commented 1 year ago

Perfect, thank you!