search

artem-ogre / CDT

Constrained Delaunay Triangulation (C++)
https://artem-ogre.github.io/CDT/
Mozilla Public License 2.0
1.07k stars 133 forks source link

Fixed a compilation issue in `generateGridVertices`. #47

Closed zhivkob closed 3 years ago

zhivkob commented 3 years ago

After changes from pull request #45 initialization with a grid no longer worked because the file didn't compile.

artem-ogre commented 3 years ago

@zhivkob Thank you for reporting the problem and fixing it. I've done the fixes based on your work here: https://github.com/artem-ogre/CDT/tree/bugfix/fix-initialize-with-grid

Could you please replace your commit with the commit from that branch 7a0b057 (it that's fine with you) and I will merge the request. I will probably make a new release right after.

artem-ogre commented 3 years ago

Nevermind, I re-based my fixes on top of your branch. Here's a PR: #48

artem-ogre commented 3 years ago

New release is up . Thank you again!

zhivkob commented 3 years ago

@artem-ogre Hi, not a problem. I would still strongly suggest to move the result into the vector to avoid the unnecessary copies (1 vector copy per grid cell) on line #88.

artem-ogre commented 3 years ago

Yes, I know. The reason I removed std::move is c++98 support in CDT. I don't think it should make a significant performance difference anyway. I could ifdef it though: ugly but portable.

artem-ogre commented 3 years ago

@zhivkob 8f1b434