search

artem-ogre / CDT

Constrained Delaunay Triangulation (C++)
https://artem-ogre.github.io/CDT/
Mozilla Public License 2.0
1.08k stars 136 forks source link

Library includes outside the "include" folder #78

Closed LeoPizzo1 closed 2 years ago

LeoPizzo1 commented 2 years ago

All source files located outside "\include" folder are referring to the library without explicitly set the relative path (it expects that "cdt.h" it is in the include search path). This forces to add the incldue folder as additional include directory (I'm using vs2019).

I think it is better to use the relative path to keep consistent with the installation.

I.e. in CDT\extras\InitializeWithGrid.h replace 

#include "CDT.h"
#include "CDTUtils.h"

with

#include "../include/CDT.h"
#include "../include/CDTUtils.h"

In case it is wanted, I think it is better to use the <> instead of the "" to clarify that the included file must be available at the root of the search path.

#include <CDT.h>
#include <CDTUtils.h>
artem-ogre commented 2 years ago

Thanks for reporting the issue! Please check if the fixes in the branch are sufficient.

LeoPizzo1 commented 2 years ago

Great, for the uses I can test it seems perfect!