artem-sedykh / mini-climate-card

Minimalistic climate card for Home Assistant Lovelace UI
MIT License
262 stars 19 forks source link

Add last-updated as an option for secondary_info type #78

Closed parrel closed 2 years ago

parrel commented 2 years ago

Did not yet add it to the Readme. Fixes #59 Fixes #63

regevbr commented 2 years ago

@parrel please rebase

parrel commented 2 years ago

@regevbr Done

regevbr commented 2 years ago

Thanks, i will merge once you update the readme

parrel commented 2 years ago

The reason because I didn't add the new option to the docs is because I don't know how you want to add it.

https://github.com/artem-sedykh/mini-climate-card/blob/f45e9567d638201856704924defb94ff3ac5a881/README.md?plain=1#L82

Do you want me to add it to this list and change the version to v2.2.0?

regevbr commented 2 years ago

The reason because I didn't add the new option to the docs is because I don't know how you want to add it.

https://github.com/artem-sedykh/mini-climate-card/blob/f45e9567d638201856704924defb94ff3ac5a881/README.md?plain=1#L82

Do you want me to add it to this list and change the version to v2.2.0?

add it there, and set v2.2.0 in parenthesis after it directly, i.e. last-changes (v2.2.0)

regevbr commented 2 years ago

@parrel do you want to complete this PR?

parrel commented 2 years ago

Hi, I'm short in time at the moment. You can do it if you want. Otherwise it will be this weekend.

regevbr commented 2 years ago

No rush just wanted to make sure this will not become stale

parrel commented 2 years ago

@regevbr Added it to the docs ;)

regevbr commented 2 years ago

thanks @parrel released in https://github.com/artem-sedykh/mini-climate-card/releases/tag/v2.1.1