artem-zinnatullin / android-wail-app

DEPRECATED Android Last.fm scrobbler. Recruiters: please don't look at this project.
MIT License
121 stars 36 forks source link

Refactored language change to support different Android Lang codes #125

Closed artem-zinnatullin closed 9 years ago

artem-zinnatullin commented 9 years ago

Some languages has display name which is different from their Android code, for example Persian code is fr

This PR brings support for lang mapping

@ilya-murzinov please review and merge if okay

artem-zinnatullin commented 9 years ago

Also, there is problem with displaying "Auto" language in "Settings" fragment

MasoudRahmani commented 9 years ago

sorry to interrupt . Persian language is Farsi and the code is FA.

wikipedia : http://en.wikipedia.org/wiki/Persian_language in language code . i think it's a standard everywhere .

artem-zinnatullin commented 9 years ago

Yes, my mistake :) When I was building a version for you I knew it

ilya-murzinov commented 9 years ago

@artem-zinnatullin, crashes at SettingsSelectLanguageFragment.java:49 if WAILSettings.getLanguage(context) is null. And doesn't display current language in main settings fragment in that case too.

artem-zinnatullin commented 9 years ago

@ilya-murzinov I'll prepare fix for that and update PR

MasoudRahmani commented 9 years ago

number one ! waiting for update .. :+1: :v:

ilya-murzinov commented 9 years ago

@artem-zinnatullin, did you abandon this?

artem-zinnatullin commented 9 years ago

Yeah, sorry for that, I need to release StorIO ASAP, if you want to handle this -> no problem.

ilya-murzinov commented 9 years ago

@regisd, if you want, we can close this PR and you can submit yours. This one isn't working anyway.

regisd commented 9 years ago

Sorry, I won't improve this feature, since I believe it should not be supported. #183

artem-zinnatullin commented 9 years ago

@ilya-murzinov feel free to close/rewrite/improve, I don't think I'll find time for this PR, I am busy with https://github.com/pushtorefresh/storio