search

artem-zinnatullin / android-wail-app

DEPRECATED Android Last.fm scrobbler. Recruiters: please don't look at this project.
MIT License
121 stars 36 forks source link

Fix Lint warnings #147

Closed ilya-murzinov closed 9 years ago

ilya-murzinov commented 9 years ago

This is the issue to start with for new developers I believe. Just run ./gradlew check and you'll see warnings in /android-wail-app/wail-app/build/outputs/lint-results.html. Not all of them are relevant, but lots of them are.

artem-zinnatullin commented 9 years ago

+1, would be nice to fix them all!

joonki34 commented 9 years ago

I am currently working on this and have a question. Would it be ok to remove unused resources, especially in strings.xml? I believe translators wouldn't want to spend their time on translating unused strings.

artem-zinnatullin commented 9 years ago

If they are really not used — delete them :)

Anyway we'll review PR.

ilya-murzinov commented 9 years ago

Fixed by #152