search

artem-zinnatullin / android-wail-app

DEPRECATED Android Last.fm scrobbler. Recruiters: please don't look at this project.
MIT License
121 stars 36 forks source link

Fix lint warnings #147 #152

Closed joonki34 closed 9 years ago

joonki34 commented 9 years ago

Fixed 56 lint warnings out of 72. Some warnings are just suppressed since they are unable to fix (e.g. ExportedReceiver lint warning).

ilya-murzinov commented 9 years ago

@joonki34, great, will review today!

artem-zinnatullin commented 9 years ago

Not sure about RTL UI now, but LGTM!

ilya-murzinov commented 9 years ago

@artem-zinnatullin, please merge it if it's OK. I'll rebase my #150 after.

artem-zinnatullin commented 9 years ago

@joonki34 can you please post screenshot with RTL changes that you've made here?

joonki34 commented 9 years ago

@artem-zinnatullin Oh, I just fixed lint warnings regarding this issue. Since I don't know any of rtl languages, I am not sure that the fixes would work on RTL UI so I can't post screenshots. Maybe I should set android:supportsRtl as false in AndroidManifest.xml for now.

ilya-murzinov commented 9 years ago

@joonki34, @artem-zinnatullin, I'm sorry, but what are you talking about? What is RLT or RTL UI? :)

ilya-murzinov commented 9 years ago

@joonki34, @artem-zinnatullin, nevermind, I get it :)

artem-zinnatullin commented 9 years ago

:) Right-To-Left, some Arabic (or Arabian) languages use RTL style. 16 июня 2015 г. 10:40 AM пользователь "Ilya Murzinov" < notifications@github.com> написал:

@joonki34 https://github.com/joonki34, @artem-zinnatullin https://github.com/artem-zinnatullin, nevermind, I get it :)

— Reply to this email directly or view it on GitHub https://github.com/artem-zinnatullin/android-wail-app/pull/152#issuecomment-112322453 .

ilya-murzinov commented 9 years ago

@artem-zinnatullin, I've tested this, seems OK to me. @joonki34, thank you for you work!

artem-zinnatullin commented 9 years ago

Great! Thanks @joonki34 and @ilya-murzinov