Refactor MD5Hash - Githubissues

artem-zinnatullin / android-wail-app

DEPRECATED Android Last.fm scrobbler. Recruiters: please don't look at this project.

MIT License

121 stars 36 forks source link

Closed regisd closed 9 years ago

regisd commented 9 years ago

Refactor MD5Hash with String.format and BigInt

Don't build the hexa string manually with a StringBuilder, but use String.format() instead. Remove static field, since MessageDigest already implements the Singleton pattern
Add MD5HashTest

Test against current behaviour, including 0-padding.

ilya-murzinov commented 9 years ago

Merging this, thank you, @regisd!

artem-zinnatullin commented 9 years ago

:+1: