search

artem-zinnatullin / android-wail-app

DEPRECATED Android Last.fm scrobbler. Recruiters: please don't look at this project.
MIT License
121 stars 36 forks source link

'Seconds' text is managed via resource bundles rather than by the code #172

Closed bassstorm closed 9 years ago

bassstorm commented 9 years ago

Hi Devs,

Noticed that "seconds" text is mentioned twice in settings (Scrobbling options). First occurrence is generated by code, and second is specified in resource bundle. I think for translators it's better to have all in one single place, and the best choice is resource bundles of course. So I updated the code and fixed German translation (not a German speaking guy, so this is to be verified for sure). Should you see any issue with this pull request - please let me know.

Thanks much, Maksim

bassstorm commented 9 years ago

Updated as per Artem comments. I'm pretty sure Ilya will completely agree.

ilya-murzinov commented 9 years ago

Merging this thanks @bassstorm!