artem-zinnatullin / android-wail-app

DEPRECATED Android Last.fm scrobbler. Recruiters: please don't look at this project.
MIT License
121 stars 36 forks source link

Scrobbling error after 0.7.3 and 0.7.4 update. #177

Closed ilya-murzinov closed 9 years ago

ilya-murzinov commented 9 years ago

I think #163 could have affected this. @artem-zinnatullin, @regisd please take a look. screenshot_2015-07-05-21-43-03 screenshot_2015-07-05-21-42-49

lemerafael commented 9 years ago

I noticed the same thing, I came here also to report the issue...

ilya-murzinov commented 9 years ago

@lemerafael, can you please share your logcat?

regisd commented 9 years ago

The same MD5 is used for the OAuth process which still works. I'm having a look.

regisd commented 9 years ago

I cannot reproduce with Google Play Music. @lemerafael What player are you using?

regisd commented 9 years ago

Is it a duplicate of issue #173 ?

lemerafael commented 9 years ago

Sure, could you give me some instructions on how to do that? (I am a beginner) Mainly, I am using Rocket Player, but I also use Play Music and Samsung Music Player sometimes. I realised when I used the Samsung Player, I got null on the first song and then the scrobble failed on all the other ones.

bassstorm commented 9 years ago

Same here. See some issues from time time (double scrobbles or a missing track - PowerAmp player) but unable to analyze. Installed aLogcat and Catlog today, but there's nothing related to WAIL there. Perhaps, it requires root?

ilya-murzinov commented 9 years ago

Hi guys, @regisd, this is not duplicate of #173. Those issue is about tracks not scrobbled by WAIL itself, this one is about WAIL being unable to send scrobbled tracks to LastFM. @lemerafael, @bassstorm, please see this article. We are looking for any exception in the log, or something like "WAILService all tracks marked as scrobbled, skipping scrobble", "WAILService tracks scrobbling to Last.fm failed with network error" or "WAILService tracks scrobbling to Last.fm failed with api error:". It would be great if you could share the whole log.

lemerafael commented 9 years ago

The failures from my logcat are:

07-13 19:27:50.882 E/WAIL (25188): WAILService tracks scrobbling to Last.fm failed with api error: Missing required parameter track[2]

07-13 19:28:00.292 W/PackageManager(28602): Failure retrieving resources for com.artemzin.android.wail: Resource ID #0x0

I would attach the full file here, but it looks like I can't. Would you have any alternate suggestion for uploading the full file? Do you need it anyway?

ilya-murzinov commented 9 years ago

@lemerafael, yes, please send it to my e-mail

ilya-murzinov commented 9 years ago

From e-mail:

You can see in the screenshot that scrobbling hangs after it reads a song that has no description. Thought you'd wanna know. Thanks for the app.

screenshot_2015-07-14-02-28-45

ilya-murzinov commented 9 years ago

Ok, I'm starting to understand the problem. Seems that after WAIL captured a track with no data it can't scrobble anymore.

ilya-murzinov commented 9 years ago

The solution is pretty obvious - we just should not add track without correct information to DB for scrobbling. @artem-zinnatullin, please verify.

artem-zinnatullin commented 9 years ago

Oh, that's bad. 14 июля 2015 г. 2:00 PM пользователь "Ilya Murzinov" < notifications@github.com> написал:

Ok, I's starting to understand the problem. Seems that after WAIL captured a track with no data it can't scrobble anymore.

— Reply to this email directly or view it on GitHub https://github.com/artem-zinnatullin/android-wail-app/issues/177#issuecomment-121201482 .

ilya-murzinov commented 9 years ago

Only one thing I can't understand - why did this came up in 0.7.3, not earlier?

artem-zinnatullin commented 9 years ago

I guess some logic of working with API was changed and it prevents sending request for scrobbling if one track can not be scrobbled.

BTW we don't only need to prevent saving tracks with incorrect info into the db, we also should delete them on app update otherwise it'll help only for new users/reinstalls. 14 июля 2015 г. 2:04 PM пользователь "Ilya Murzinov" < notifications@github.com> написал:

Only one thing I can't understand - why did this came up in 0.7.3, not earlier?

— Reply to this email directly or view it on GitHub https://github.com/artem-zinnatullin/android-wail-app/issues/177#issuecomment-121202071 .

ilya-murzinov commented 9 years ago

@artem-zinnatullin, yes, you are right. I will submit the solution ASAP.

ilya-murzinov commented 9 years ago

Fixed in #186, thanks, guys!