search

artem-zinnatullin / android-wail-app

DEPRECATED Android Last.fm scrobbler. Recruiters: please don't look at this project.
MIT License
121 stars 36 forks source link

Remove support for custom language #183

Closed regisd closed 9 years ago

regisd commented 9 years ago

Currently, WAIL supports a setting whereby the user can choose a different language.

Locales are already natively handled by the platform. I don't think the setting that let the user choose a different language makes sense.

Removing this feature:

artem-zinnatullin commented 9 years ago

No, please, I usually use English system but I live in Russia, and I prefer to use some (not all but a few) apps in Russian, so these feature makes sence at least for me, but it's not so critical.

Also, it makes testing of different languages easier because it does not require changing system language.

@ilya-murzinov thoughts?

joonki34 commented 9 years ago

I also use English settings although I live in Korea. Adding 'device language' option as default like Facebook app would be helpful.

regisd commented 9 years ago

The default language is already "Auto", which is the locale of the device.

ilya-murzinov commented 9 years ago

I would agree with @regisd. As a developer, I'd like to remove as much as possible. As a user, I always use English locale anyway.

I think we can remove it and see how people react.

artem-zinnatullin commented 9 years ago

I guess we'll receive only negative feedback, because most of users even don't know that they can change language in tg the app, but little part that use it will be angry. 14 июля 2015 г. 8:58 PM пользователь "Ilya Murzinov" < notifications@github.com> написал:

I would agree with @regisd https://github.com/regisd. As a developer, I'd like to remove as much as possible. As a user, I always use English locale anyway.

I think we can remove it and see how people react.

— Reply to this email directly or view it on GitHub https://github.com/artem-zinnatullin/android-wail-app/issues/183#issuecomment-121323769 .

ilya-murzinov commented 9 years ago

Yes, I worry about this too.

artem-zinnatullin commented 9 years ago

So, I am closing this for now, feel free to reopen/comment.