Issue 120 - Widget

[kramer]

120 - A simple widget with a "Love Track" button and "Now Scrobbling" info. If widget size is smaller than 3 columns then only the button is shown (the number used to determine number of cells -that is 179 in code- is supposedly not a magic number (70x3-30=180).

Tested only on my Nexus 5.

Please share your opinion.

[ilya-murzinov]

@kramer, please rebase this.

[kramer]

@ilya-murzinov done

[ilya-murzinov]

@kramer please add all strings translations as well. Just copy-paste them from the main strings.xml.

[artem-zinnatullin]

I'll take a look at this tonight.

[artem-zinnatullin]

@kramer can you please add some screenshots as comment to the PR?

[artem-zinnatullin]

LGTM, but comments!

[kramer]

Screenshots:

• 1 cell:
• 4 cells (no info shown when app is disabled or never opened):
• 4 cells with nothing scrobbling info:
• 4 cells with now scrobbling info:
• 3 cells:
• 2 cells:

[kramer]

Will apply the changes you mentioned @artem-zinnatullin, thanks for the feedback. I want to emphasise again that this should be tested on a device other than my N5 :).

[artem-zinnatullin]

Nice! I'll just add gravity=center_vertical for 3rd screenshot

[kramer]

I'll just add gravity=center_vertical for 3rd screenshot

Yup that sticks out :) All the solutions I could think of for that included having some layout related/changing code in WAILService.updateWidget and I was not quite comfortable and sure with having that.

[artem-zinnatullin]

@kramer may be just display "Now scrobbling" as song name and "Nothing" as artist name?

[ilya-murzinov]

@kramer, this is very good job, thank you!

[kramer]

@artem-zinnatullin did exactly that now.

@ilya-murzinov You're welcome, glad to contribute.

[ilya-murzinov]

I don't have time to take a closer look. @artem-zinnatullin, please merge this if you think it's ok.

[artem-zinnatullin]

@ilya-murzinov unfortunately, I have problems with free time too :(

I think it's okay, but would be nice if we could test it on more devices.

[artem-zinnatullin]

I think we can say that widget is in beta mode and ship it :shipit: to the users!

Thanks @kramer!

[kramer]

@artem-zinnatullin #120 is still open though...

[ilya-murzinov]

@kramer, if you wonder why didn't it close automatically, you should have written "Resolves/closes/solves #120" in first comment for this. I'll close it.

[kramer]

@ilya-murzinov I realised that just a bit late, thanks!