artem-zinnatullin / android-wail-app

DEPRECATED Android Last.fm scrobbler. Recruiters: please don't look at this project.
MIT License
121 stars 36 forks source link

New nav. drawer #95

Closed ilya-murzinov closed 9 years ago

ilya-murzinov commented 9 years ago

Thanks to this review on Google Play.

Последнее обновление вообще шикарно, но гайдлайны автору все же лучше перечитать :) Иконка поиска и боковое меню не вписываются.

Guidelines: navigation drawer

ilya-murzinov commented 9 years ago

@artem-zinnatullin, drawer not finished but idea is: screenshot_2015-01-22-13-50-05

artem-zinnatullin commented 9 years ago

@ilya-murzinov cool, also will be great to add some image into drawer, like Pushbullet, or Gmail, or Google Play

ср, 21 янв. 2015, 21:02, Ilya Murzinov notifications@github.com:

@artem-zinnatullin https://github.com/artem-zinnatullin, drawer not finished but idea is: [image: screenshot_2015-01-21-21-00-32] https://cloud.githubusercontent.com/assets/3704363/5841791/b0ea8b32-a1b0-11e4-8282-d317f86348ca.png

— Reply to this email directly or view it on GitHub https://github.com/artem-zinnatullin/android-wail-app/issues/95#issuecomment-70888198 .

ilya-murzinov commented 9 years ago

@artem-zinnatullin, I updated preview above. Any idea what kind of picture can we use in background?

artem-zinnatullin commented 9 years ago

@ilya-murzinov can you please check Public Licence of standard Lolipop wallpapers? if it's okay, you can put one of them into Nav Drawer, also, would be better if Nav Drawer will be under status bar on Lolipop (see apps I mentioned earlier)

ilya-murzinov commented 9 years ago

@artem-zinnatullin, is landscape layout ok? I tested om Nexus 5, not tablet of course. screenshot_2015-01-22-18-16-48 screenshot_2015-01-22-18-16-52

artem-zinnatullin commented 9 years ago

@ilya-murzinov I'll be able to test in several hours, if you want to do it yourself, I'd recommend to use Genymotion they have Nexus 7, Nexus 10 configurations of emulators, Genymotion emulators are great

ilya-murzinov commented 9 years ago

It's still not ready for testing, I just wonder if you like how it looks. On Jan 22, 2015 6:41 PM, "Artem" notifications@github.com wrote:

@ilya-murzinov https://github.com/ilya-murzinov I'll be able to test in several hours, if you want to do it yourself, I'd recommend to use Genymotion they have Nexus 7, Nexus 10 configurations of emulators, Genymotion emulators are great

— Reply to this email directly or view it on GitHub https://github.com/artem-zinnatullin/android-wail-app/issues/95#issuecomment-71039821 .

artem-zinnatullin commented 9 years ago

@ilya-murzinov Ui LGTM, icons, user info, Navigation Drawer hipster pack for Android App :+1:

ilya-murzinov commented 9 years ago

@artem-zinnatullin should we highlight current item in drawer? I can't decide :)

artem-zinnatullin commented 9 years ago

@ilya-murzinov yes, of course, check several apps and decide how to do it :)

ilya-murzinov commented 9 years ago

@artem-zinnatullin, almost final version: screenshot_2015-01-23-16-10-41

artem-zinnatullin commented 9 years ago

@ilya-murzinov cool, let's publish it :+1: