search

artem-zinnatullin / jet-image-loader

WP7+ fast and powerfull image loader with memory and storage caching for your projects!
Apache License 2.0
44 stars 14 forks source link

Added wp7 support. #17

Closed ghost closed 10 years ago

ghost commented 10 years ago

Tested on Lumia 800.

artem-zinnatullin commented 10 years ago

Wow wow easier :)

It will be enough to just write in README.md something like "if you want to user JetImageLoader in wp7 project you need to reference Microsoft.Bcl library to provide support for async/await instructions. "

You can add dependency on that lib via NuGet: PM> Install-Package Microsoft.Bcl

Attaching executable files in repository is very bad practice, files like NuGet.exe should never be part of project sources :) Project should contain just sources.

Also, I don't think, that we need to create JetImageLoaderWp7 folder for that purposes, because source code wouldn't be changed for wp7, referencing Microsoft.Bcl is enough for that

artem-zinnatullin commented 10 years ago

I just wanted to give you little task with updating README.md about using JetImageLoader in wp7 projects and you will became project contributor :)

ghost commented 10 years ago

Hm.. what would be the easiest way to keep wp7 version easy-to-build? I though, having separate project and linking new files would be pretty ok.

Actually, i can do that: sample is a bit outdated :)

artem-zinnatullin commented 10 years ago

Easiest way would be: install Microsoft.Bcl from NuGet and use JetImageLoader in wp7 project :)

ghost commented 10 years ago

There's no possibility to downgrade Wp8 project (or library) to Wp7, and Wp8 library would not work with Wp7 project, so only adding Bcl to project would not help. So, i created new wp7 library, linked your files, added Bcl, and so on.. it took dozen of minutes - maybe there can be easier way?)

artem-zinnatullin commented 10 years ago

Oh, you are right. I forgot that new project required for that. Hmm.. May be we need structure like: JetImageLoaderCore, JetImageLoaderWP8, JetImageLoaderWP7, JetImageLoaderWindowsStore

ghost commented 10 years ago

Hm.. but what would be in Core and in Wp8?

Well... probably, something like:

ghost commented 10 years ago

Pushed fixed LimitedStorageCache for wp7.

ghost commented 10 years ago

And why it is pushed with my another account? In a GitHub app i'm registered as current user.

artem-zinnatullin commented 10 years ago

This pull request will be changed with another one, closing