search

artemanufrij / playmymusic

An elementary OS app
http://anufrij.org/melody
98 stars 26 forks source link

Fix playlist import on relative paths and symlinks #164

Closed streambinder closed 5 years ago

artemanufrij commented 5 years ago

hey @streambinder. Thank you for your PR. I will test it in 2 days.

streambinder commented 5 years ago

New about this? Have you got time to check it?

artemanufrij commented 5 years ago

could you move your fix into LocalFileManager.vala?

I have already a block for a symlink test: https://github.com/artemanufrij/playmymusic/blob/master/src/Services/LocalFilesManager.vala#L63

streambinder commented 5 years ago

What do you mean? It seems there you scan a given path to find new music files, that's not what's needed to be fixed. The issue is where you scan playlist files, reading entries that could point to symlinks and not directly to a library music file. You want me to move the file handle part of playlist import into the LocalFileManager?

streambinder commented 5 years ago

As requested, moved all the fix logic into the LocalFileManager and reduced the code portion which the LibraryManager is involved in to the minimum requested to parse playlist entries.

streambinder commented 5 years ago

Got time to check it?

eugeneia commented 5 years ago

Bump, I need this. :-)

streambinder commented 5 years ago

@artemanufrij , nothing new about this one?

streambinder commented 5 years ago

Are you ever going to merge this, @artemanufrij ?