Capabilities request: Dynamically update Tag info to DB

dmanlfc commented 6 years ago

Hi @artemanufrij

I've noticed some inconsistencies with song tagging in my Library which I'm slowly tidying up. i.e. Lady GaGa vs Lady Gaga or Guns 'N' Roses vs Guns N' Roses. (Don't judge me, this is a shared Music library unfortunately :-) )

If you change / fix some tags (i.e. using MusicBrainz Picard) after the initial DB import the old tags are still shown in PlayMyMusic. It would be great if your app automatically updated the tags to the DB in this scenario & removed older references. This goes the same for Files that have been renamed.

Maybe changing what 'Rescan Library' does - Just to update & remove orphans rather than clear & update.

Something to think about...

Dan

artemanufrij commented 6 years ago

In case of " Lady GaGa vs Lady Gaga": I could ignore lower and upper cases for checking artist name. It would be easy to fix.

dmanlfc commented 6 years ago

@artemanufrij that won't fix the ability to update the DB. I had a quick look through the code. The 'Rescan Library' option is misleading.

Rescan should do exactly that & not drop the DB but you actually 'Reset it'
Currently it resets the view & DB via reset_all_views (); & db_manager.reset_database ();

Ideally those calls should be avoided & then we probably need some methods to 'update' & 'dispose' (in the event the filename is different) the DB tags that already exist via LibraryManager.vala.

artemanufrij commented 6 years ago

An option like Sync? No problem...

dmanlfc commented 6 years ago

Sync, Re-Sync, Refresh - just not Reset :-)

artemanufrij commented 6 years ago

@dmanlfc I changed it. Now it will resync library. It means: add new music files into library and remove all non exists items from library. could you test it?

dmanlfc commented 6 years ago

@artemanufrij unfortunately it crashes...

(com.github.artemanufrij.playmymusic:11744): WARNING : TagManager.vala:63: DISCOVER ERROR: '3' Resource not found. GST_DISCOVERER_ERROR (file:///home/dman/Music/Destinys Child - #1's/03 - Survivor.mp3)

(com.github.artemanufrij.playmymusic:11744): WARNING : TagManager.vala:63: DISCOVER ERROR: '3' Resource not found. GST_DISCOVERER_ERROR (file:///home/dman/Music/Destinys Child - #1's/05 - Check On It (Beyonce ft.Slim Thug).mp3) Segmentation fault (core dumped)

artemanufrij commented 6 years ago

fixed crash on url's with a #

artemanufrij / playmymusic

Capabilities request: Dynamically update Tag info to DB #35