search

artemanufrij / regextester

An elementary OS app
https://artemanufrij.github.io
38 stars 10 forks source link

add support for pcre flags. #23

Open ahmubashshir opened 4 years ago

ahmubashshir commented 4 years ago

please add support for /pattern/FLAGS

nPHYN1T3 commented 2 years ago

@devhammed what's going on with all that. It's been 2 years heh.

devhammed commented 2 years ago

@devhammed what's going on with all that. It's been 2 years heh.

@nPHYN1T3 The project owner hasn't merged my PR yet :rofl:

I suggest you download my branch instead and build locally.

nPHYN1T3 commented 2 years ago

I tried that and same same. Tried both the master zip and cloning from https://github.com/devhammed/regextester.git.

devhammed commented 2 years ago

@nPHYN1T3 I didn't add the new features in the master branch.

Check the other branch.

nPHYN1T3 commented 2 years ago

The other other branch...this is starting to feel like a tree ;) Why didn't you add them to your own master branch?

ahmubashshir commented 2 years ago

On Fri, Jul 8 2022 at 11:58:05 AM -0700, nPHYN1T3 @.***> wrote:

The other other branch...this is starting to feel like a tree ;)

Well, they're called tree^1.

Mubashshir
nPHYN1T3 commented 2 years ago

Yes I know hence the ;) to which now I need to add ;p

devhammed commented 2 years ago

The other other branch...this is starting to feel like a tree ;) Why didn't you add them to your own master branch?

I needed to create a PR.

nPHYN1T3 commented 2 years ago

Either way thanks for the tweak.