artemave / translate_onhover

Browser translation extension
https://chrome.google.com/webstore/detail/aggiiclaiamajehmlfpkjmlbadmkledi
205 stars 61 forks source link

Feature #111: Translation History #113

Open 0x6362 opened 1 week ago

0x6362 commented 1 week ago

@artemave: Tried to keep this in the style of the existing code and refactor as little as possible, very much an MVP of the functionality to get your feedback

RE: storage and export. Went with JSON instead of CSV, which possibly less accessible to users by default. Happy to create a setting to support export in either.

Other call out is the addition of the dexie dependency. I would prefer not to implement code for handling IndexedDB migrations/schema changes myself, but I've done it before and can do it here if you would prefer not to add a dep.


TODO

artemave commented 1 week ago

RE: storage and export. Went with JSON instead of CSV, which possibly less accessible to users by default. Happy to create a setting to support export in either.

Probably best to add CSV as a follow up pr.

artemave commented 1 week ago

Other call out is the addition of the dexie dependency

Adding dexie seems reasonable to me.