artemave / translate_onhover

Browser translation extension
https://chrome.google.com/webstore/detail/aggiiclaiamajehmlfpkjmlbadmkledi
205 stars 61 forks source link

doesnt register numbers like 1234 #63

Closed cellurl3 closed 4 years ago

cellurl3 commented 4 years ago

Looking at console, it seems to get numbers not always. image

I am set to hoover-over, not click. Words light up normally, but hoovering over a number like 1234 doesnt "hit". If I click and highlight the number it works, but then it gets stuck just registering the hightlighted number forever until I unhighlight it.

No biggie, but I am more interested in numbers sometimes....

Q: Where is your tip jar??

artemave commented 4 years ago

Yeah I don't think numbers were ever meant to work. I mean, you know that '1234' is '1234'. Don't need to translate that, do you?

cellurl3 commented 4 years ago

Curious how the code knows to not send it to the webservice??

artemave commented 4 years ago

Using regular expression. If something under the cursor looks like a word, translate it.