artemgordinskiy / Spotifree

An OS X app that automatically mutes ads on Spotify [DISCONTINUED]
http://spotifree.gordinskiy.com
MIT License
1.05k stars 70 forks source link

won't mute Ads #44

Closed anonmoez closed 9 years ago

anonmoez commented 9 years ago

For a few weeks my Spotifree won't block the Ads on my mac. I tried to reinstall, but it didn't fix the issue. It's still active and there are no Update available. Do you have any thoughts?

Pesa commented 9 years ago

Same problem here, Spotify version 0.9.16.19.g1c9463fe

artemgordinskiy commented 9 years ago

Hey guys, Have you tried reinstalling Spotify using these instructions? There seems to be a glitch in Spotify breaking the AppleScript interface on update sometimes, and it usually goes away after a complete reinstall.

Pesa commented 9 years ago

Reinstalling put an older version (0.9.15.27.g87efe634) on my system, so I'm unable to say whether the problem is really fixed until Spotify decides to update itself again.

ghost commented 9 years ago

Have you tried a command+alt+escape forcequit + relaunch of spotifree and spotify after reinstall of both spotify and spotifree?

Pesa commented 9 years ago

What's that supposed to accomplish?

artemgordinskiy commented 9 years ago

@Pesa Have you received any updates yet?

Pesa commented 9 years ago

nothing yet

anonmoez commented 9 years ago

@ArtemGordinsky The instructions seemd to work for me, thx.

iiiGerardoiii commented 9 years ago

yup, that fixed it @ArtemGordinsky, thanks

Everyone do what Artem said!

didjeridou commented 9 years ago

Worked for me too! Thanx @ArtemGordinsky

fait1ux commented 9 years ago

Unfortunately I am still having this problem. When spottily is open and playing music already then spotifree instantly gets shutdown and disappears from my dock. Keep repeating and same action occurs. Sometimes I can get spotifree to stay in dock by opening first and then spottily, and says its blocking ads but it doesn't. Sorry Mr. Gordinsky for the trouble. I tried your instructions again to no avail, but perhaps I am doing it wrong. All the best sir.

artemgordinskiy commented 9 years ago

@fait1ux Spotifree does not retain its Dock icon once it's launched. Do you see it in the menubar?

Pesa commented 9 years ago

I finally received the update, to version 0.9.16.25.g241bf986 this time, and Spotifree broke again.

artemgordinskiy commented 9 years ago

@Pesa Okay, let's try and figure out what's going on:

  1. Download this script, run it and give me the results. Like this: screen shot 2015-03-03 at 8 45 23 am
  2. Follow the Spotify reinstallation instructions again, but skip the 6th step. Then relaunch the app and wait for an ad to come on. This will tell us if this version breaks Spotifree indeed.
shaharz commented 9 years ago

https://community.spotify.com/t5/Help-Desktop-Linux-Mac-and/New-Mac-Update-AppleScript-support-removed/td-p/995843

@ArtemGordinsky FYI, your debug script fails with "Syntax Error: Expected end of line but found identifier." on "state". In addition, "Open Dictionary..." doesn't seem to work for Spotify.app anymore. :disappointed:

artemgordinskiy commented 9 years ago

@shaharz I hope the Spotify team has simply delayed the AppleScript implementation in the new version. Either that, or the day of Spotifree's demise has finally come.

Pesa commented 9 years ago

This is the output of the script when a spot is playing:

tell application "Spotify"
    get player state
        --> playing
    get artist of current track
        --> "Spotify"
    get name of current track
        --> "Spotify"
    get duration of current track
        --> 26
    get popularity of current track
        --> 0
    get track number of current track
        --> 0
end tell
Result:
0

and when an actual song is playing:

tell application "Spotify"
    get player state
        --> playing
    get artist of current track
        --> "Cream"
    get name of current track
        --> "I'm So Glad - Live"
    get duration of current track
        --> 379
    get popularity of current track
        --> 41
    get track number of current track
        --> 1
end tell
Result:
1
artemgordinskiy commented 9 years ago

Thanks! This is version 1.0.1, right? And Spotifree doesn't work?

Pesa commented 9 years ago

version 0.9.16.25.g241bf986

I also reset Caches and Application Support, and it still doesn't mute ads.

artemgordinskiy commented 9 years ago

Okay. Does Spotifree become "active" when Spotify is playing? Have you tried restarting it? Also, would you please run the script again when an ad comes on and tell me what it returns?

Pesa commented 9 years ago

Does Spotifree become "active" when Spotify is playing?

Yes.

Have you tried restarting it?

Yes, no change.

Also, would you please run the script again when an ad comes on and tell me what it returns?

See my previous comment above.

enellis commented 9 years ago

Found the bug. I'll fix it soon.

enellis commented 9 years ago

Does everything work with the latest Spotify and Spotifree now?

thibmaek commented 9 years ago

Nope, I just updated to 1.0.1.1060.gc75ebdfd but Spotifree is not blocking ads

enellis commented 9 years ago

Did you also update Spotifree to version 1.6? And restarted everything?

Pesa commented 9 years ago

Spotifree v1.6 works for me (with Spotify 1.0.1.1060)

Thanks a lot for the quick fix!

Usbloom commented 9 years ago

it does not work for me. (spotify free 1.0.1.1060.gc75ebdfb / spotifree 1.6). Spotifree does a single time, then I have to close & restart it to work again.

ghost commented 9 years ago

@ArtemGordinsky Relax man Spotify hasn't done anything because the rest of the people not commenting, for them its working perfectly. These are the only few people who are having issues.

enellis commented 9 years ago

I think this is fixed for everyone who uses the latest Spotify & latest Spotifree.