artemgordinskiy / Spotifree

An OS X app that automatically mutes ads on Spotify [DISCONTINUED]
http://spotifree.gordinskiy.com
MIT License
1.05k stars 70 forks source link

Crash on 1.0.1.1060.gc75ebdfd [1.6] #47

Closed artemgordinskiy closed 9 years ago

artemgordinskiy commented 9 years ago

Description by the user: Spotify is running > I launch Spotifree > SF appears in menubar & Activity Monitor for 5 sec > SF disappears from both.

11/03/2015 19:02:11.310 Spotlight[933]: LSExceptions [0x6080002ba820] unloaded
11/03/2015 19:02:12.429 Console[3823]: LSExceptions [0x6000000a5a60] unloaded
11/03/2015 19:02:12.711 Spotlight[933]: LSExceptions [0x6080004b05c0] loaded
11/03/2015 19:02:12.726 taskgated[94]: no system signature for unsigned /Applications/Spotifree.app[3828]
11/03/2015 19:02:12.765 Spotifree[3828]: LSExceptions [0x6080000a9180] loaded
11/03/2015 19:02:12.944 Spotifree[3828]: Performance: Please update this scripting addition to supply a value for ThreadSafe for each event handler: "/Library/ScriptingAdditions/Google Authenticator BT.osax"
11/03/2015 19:02:12.992 taskgated[94]: binary have embedded signature that validated /System/Library/CoreServices/System Events.app[3829]
11/03/2015 19:02:13.035 System Events[3829]: LSExceptions [0x6000000ba7c0] loaded
11/03/2015 19:02:13.382 Spotifree[3828]: warning: failed to get scripting definition from /Users/user/Applications/Spotify.app; it may not be scriptable.
11/03/2015 19:02:13.383 Spotifree[3828]: -[SBApplication playerState]: unrecognized selector sent to instance 0x608000241140
11/03/2015 19:02:13.384 Spotifree[3828]: An uncaught exception was raised
11/03/2015 19:02:13.384 Spotifree[3828]: -[SBApplication playerState]: unrecognized selector sent to instance 0x608000241140
11/03/2015 19:02:13.385 Spotifree[3828]: (
    0   CoreFoundation                      0x00007fff8f3cf66c __exceptionPreprocess + 172
    1   libobjc.A.dylib                     0x00007fff8d11d76e objc_exception_throw + 43
    2   CoreFoundation                      0x00007fff8f3d26dd -[NSObject(NSObject) doesNotRecognizeSelector:] + 205
    3   CoreFoundation                      0x00007fff8f319aa4 ___forwarding___ + 1028
    4   CoreFoundation                      0x00007fff8f319618 _CF_forwarding_prep_0 + 120
    5   Spotifree                           0x0000000100001ac3 Spotifree + 6851
    6   Spotifree                           0x00000001000013e6 Spotifree + 5094
    7   Spotifree                           0x000000010000145d Spotifree + 5213
    8   Spotifree                           0x000000010000287c Spotifree + 10364
    9   CoreFoundation                      0x00007fff8f2dd85f -[NSSet makeObjectsPerformSelector:] + 223
    10  AppKit                              0x00007fff89d295cd -[NSIBObjectData nibInstantiateWithOwner:options:topLevelObjects:] + 1216
    11  AppKit                              0x00007fff89839605 loadNib + 384
    12  AppKit                              0x00007fff89daa5ab +[NSBundle(NSNibLoading) _loadNibFile:nameTable:options:withZone:ownerBundle:] + 313
    13  AppKit                              0x00007fff89838cd5 -[NSBundle(NSNibLoading) loadNibNamed:owner:topLevelObjects:] + 201
    14  AppKit                              0x00007fff89838aa1 +[NSBundle(NSNibLoading) loadNibNamed:owner:] + 344
    15  AppKit                              0x00007fff89834549 NSApplicationMain + 605
    16  Spotifree                           0x0000000100001094 Spotifree + 4244
)
11/03/2015 19:02:13.385 Spotifree[3828]: *** Terminating app due to uncaught exception 'NSInvalidArgumentException', reason: '-[SBApplication playerState]: unrecognized selector sent to instance 0x608000241140'
*** First throw call stack:
(
    0   CoreFoundation                      0x00007fff8f3cf66c __exceptionPreprocess + 172
    1   libobjc.A.dylib                     0x00007fff8d11d76e objc_exception_throw + 43
    2   CoreFoundation                      0x00007fff8f3d26dd -[NSObject(NSObject) doesNotRecognizeSelector:] + 205
    3   CoreFoundation                      0x00007fff8f319aa4 ___forwarding___ + 1028
    4   CoreFoundation                      0x00007fff8f319618 _CF_forwarding_prep_0 + 120
    5   Spotifree                           0x0000000100001ac3 Spotifree + 6851
    6   Spotifree                           0x00000001000013e6 Spotifree + 5094
    7   Spotifree                           0x000000010000145d Spotifree + 5213
    8   Spotifree                           0x000000010000287c Spotifree + 10364
    9   CoreFoundation                      0x00007fff8f2dd85f -[NSSet makeObjectsPerformSelector:] + 223
    10  AppKit                              0x00007fff89d295cd -[NSIBObjectData nibInstantiateWithOwner:options:topLevelObjects:] + 1216
    11  AppKit                              0x00007fff89839605 loadNib + 384
    12  AppKit                              0x00007fff89daa5ab +[NSBundle(NSNibLoading) _loadNibFile:nameTable:options:withZone:ownerBundle:] + 313
    13  AppKit                              0x00007fff89838cd5 -[NSBundle(NSNibLoading) loadNibNamed:owner:topLevelObjects:] + 201
    14  AppKit                              0x00007fff89838aa1 +[NSBundle(NSNibLoading) loadNibNamed:owner:] + 344
    15  AppKit                              0x00007fff89834549 NSApplicationMain + 605
    16  Spotifree                           0x0000000100001094 Spotifree + 4244
)
11/03/2015 19:02:13.405 com.apple.xpc.launchd[1]: (com.apple.ReportCrash[3831]) Endpoint has been activated through legacy launch(3) APIs. Please switch to XPC or bootstrap_check_in(): com.apple.ReportCrash
11/03/2015 19:02:14.022 com.apple.xpc.launchd[1]: (de.eneas.Spotifree.55412[3828]) Service exited due to signal: Abort trap: 6
11/03/2015 19:02:14.068 ReportCrash[3831]: Saved crash report for Spotifree[3828] version 1.6 (1.6) to /Users/user/Library/Logs/DiagnosticReports/Spotifree_2015-03-11-190214_user-Air.crash
11/03/2015 19:02:22.712 Spotlight[933]: LSExceptions [0x6080004b05c0] unloaded
11/03/2015 19:02:24.027 System Events[3829]: LSExceptions [0x6000000ba7c0] unloaded
11/03/2015 19:02:30.107 taskgated[94]: binary have embedded signature that validated /System/Library/CoreServices/ManagedClient.app[3887]
11/03/2015 19:02:32.087 taskgated[94]: binary have embedded signature that validated /usr/sbin/diskmanagementd[3891]
11/03/2015 19:02:33.728 com.apple.xpc.launchd[1]: (com.apple.CoreRAID[3896]) Endpoint has been activated through legacy launch(3) APIs. Please switch to XPC or bootstrap_check_in(): com.apple.CoreRAID
enellis commented 9 years ago

Did he edit the Spotify.sdef file? He should try to delete Spotify.sdef just from the Spotify.app/Contents/Resources folder and restart Spotify. Then Spotifree should apply the fix normally and it should not crash.

Editing this file the wrong way was the only way for me to reproduce the error.

artemgordinskiy commented 9 years ago

Says he didn't edit it, and that his other Mac has the same issue.

enellis commented 9 years ago
  1. Did he try to redownload / reinstall Spotify?
  2. If reinstalling doesn't work, he should try to replace
    Spotify.app/Contents/Resources/Spotify.sdef
    and
    Spotify.app/Contents/Resources/applescript/Spotify.sdef
    with this file: https://www.dropbox.com/s/xuq57ag6980340q/Spotify.sdef?dl=1
artemgordinskiy commented 9 years ago

Got a couple more such reports. Asked for users' Spotify.sdef files to see if it they may have been corrupted on copy. Update: got one the files.

enellis commented 9 years ago

OK. In this file are some crucial changes which cause Spotifree to stop working : https://www.diffchecker.com/atjayuwz
But anyway, on my Mac it just breaks Spotifree. It doesn't crash.

enellis commented 9 years ago

So apparantly it's the Spotify.sdef file from Spotify 0.9.x so there are these two options:

  1. They still use the old Spotify which should be no problem because this file works with Spotify 0.9.x and the latest Spotifree. (This file won't work with Spotify 1.0.1, though) Edit: Apparantly Spotifree 1.6 isn't compatible with Spotify 0.9.x anymore!
  2. They use the latest Spotify but still have the old Spotify.sdef file. In this case they should try exactly what I wrote earlier. (Replacing both Spotify.sdef files with the file from the download)
artemgordinskiy commented 9 years ago

Strangely, the file was taken from Spotify 1.0.1.1060. I wonder how this could have happened? A broken build maybe?

artemgordinskiy commented 9 years ago

Looks like 1.6.1 fixed it.