artemgordinskiy / Spotifree

An OS X app that automatically mutes ads on Spotify [DISCONTINUED]
http://spotifree.gordinskiy.com
MIT License
1.05k stars 70 forks source link

Why Spotifree stuck at mute state after ad? #50

Closed fehmi closed 9 years ago

fehmi commented 9 years ago

Not everytime but sometimes. I don't know how you can reproduce this issue but it is really annoying.

gedeminas commented 9 years ago

Same here, I stopped using Spotifree, temporarily I hope.

enellis commented 9 years ago

I'm really sorry, but I don't have any time to fix anything until Friday. Maybe the experimental version does it for you until I can focus on Spotifree again. Or maybe somebody else knows how to fix this :)

artemgordinskiy commented 9 years ago

Hey guys, Never heard of this issue before. What are your Spotifree and Spotify versions? Can you recall when this started happening?

joshwertheim commented 9 years ago

Hey @ArtemGordinsky.

It's happening to me too. Running Spotify (ver. 1.0.1.1060.gc75ebdfd) and Spotifree (ver. 1.6).

Doesn't seem to happen after every ad, but it probably happens about half the time.

gedeminas commented 9 years ago

Hey, if I recall correctly it started happening only after latest Spotify update (to 1.0.1.1060.gc75ebdfd) and Spotifree update (to 1.6). And I updated both of them in one day, so.

flopflip21 commented 9 years ago

Same as above

gkiely commented 9 years ago

Same issue, will work fine for a few ads then it mutes everything.

Spotify version: 1.0.1.1060.gc75ebdfd Spotifree version: 1.6 Yosemite 10.10.2

It also disables all sounds for my macbook and the only way I've found to get it back is by restarting.

artemgordinskiy commented 9 years ago

@gkiely Wait, Spotifree shouldn't mangle with the system sound at all. Are you sure you don't have some other apps like smutefy or soundflower installed? Can you look for something spotifree- or sound-related in the Console when this happens?

Is anyone else's system sound being disabled by Spotifree?

joshwertheim commented 9 years ago

For me it's only been Spotify sound. Hasn't happened at all today. It's definitely sporadic. I'm trying to be observant. If it happens again I'll check out my Console and get back to you with some logs.

Usbloom commented 9 years ago

Version 1.6.1 doesn't always work for me (Maverick 10.9.5). An half the time, the sound isn't muted or sometimes Spotify (1.0.1.1060.gc75ebdfd) suddenly crashed. … (?) But thank you already for the job! and I'm sure that everything will be fine soon !

fehmi commented 9 years ago

I think i found! If ad plays after the last song in a playlist Spotify stuck at mute state.

Spotifree 1.6.1 Spotify 1.0.1.1060.gc75ebdfd

artemgordinskiy commented 9 years ago

That is really helpful. Thanks, @fehmi!

Update: Managed to reproduce the bug. Will try and fix in the coming days.

Usbloom commented 9 years ago

I notice that spotifree works with a specifically Spotify advertising (hits etc.) but not with an ads of a trademark.

aravind-pg commented 9 years ago

I'm not sure the commit above actually made it to the packaged form of the app, because the current version num is 1.6.1, whereas in the commit it looks like it's been updated to 1.6.2, and the issue still occurs occasionally. Please update the app on the spotifree.gordinskiy.com website if so. Thanks for your work on this app!

In the future, also consider tagging release points and using GitHub's releases feature so that we can download straight from here and also see what commits made it into a release.

artemgordinskiy commented 9 years ago

Hey guys, Finally got some time to work on an update. It should catch all ads now, and not get stuck at "muting" state. Can you try it out? http://d.pr/f/19FIk

fehmi commented 9 years ago

The problem still exist. I don't know when it happens but happens from time to time.

artemgordinskiy commented 9 years ago

@fehmi I have taken another stab at fixing these and other issues. Any help with testing will be appreciated: http://d.pr/f/T6oq

tonlam commented 6 years ago

Hi guys I still have this issue.