search

artemgordinskiy / Spotifree

An OS X app that automatically mutes ads on Spotify [DISCONTINUED]
http://spotifree.gordinskiy.com
MIT License
1.05k stars 70 forks source link

Eliminate tiny duration of ad sound #61

Closed kwigginton closed 8 years ago

kwigginton commented 9 years ago

Some small duration (~0.3 seconds) would slip through after the url scheme was changed from ad to a new song.

apple-ihack-geek commented 9 years ago

Interesting, if you look at #60 I've had the opposite issue at the end of a track

kwigginton commented 9 years ago

@apple-ihack-geek Interesting, I have also begun to see this same issue. I'll try fixing that as well.

artemgordinskiy commented 8 years ago

Hi, Can you tell me how often do you hear bits of ads after they're unmuted? Asking because Spotifree delayed unmuting for 0.3 seconds or so ever since the AppleScript implementation. Later the delay was removed, when some people complained that it was cutting off about half-second at the start of a track. Kinda funny seeing it coming back again.

kwigginton commented 8 years ago

Hey there!

It's nearly every ad track. The bits sneak through at both the beginning and end of the track. I investigated trying to tackle the beginning of the track but given my limited scripting bridge experience, I soon found out that KVO isn't an option there, and there's no notifications for an ad beginning.

We could reduce the timer duration to poll every few milliseconds, it's likely that will catch it.

Sent from my iPhone

On Nov 22, 2015, at 10:57 AM, Artem Gordinsky notifications@github.com wrote:

Hi, Can you tell me how often do you hear bits of ads after they're unmuted? Asking because Spotifree delayed unmuting for 0.3 seconds or so ever since the AppleScript implementation. Later the delay was removed, when some people complained that it was cutting off about half-second at the start of a track. Kinda funny seeing it coming back again.

— Reply to this email directly or view it on GitHub.

artemgordinskiy commented 8 years ago

I have decreased the polling delay from 0.5 to 0.3 in hopes that it would solve (or improve on) such issues. Long-term though, some kind of a frequency setting would be very nice indeed. Closing this for now, don't hesitate to tell if things don't improve.

tomglynch commented 7 years ago

Hi, after looking back this seems to be the same as #87 . Potentially should re-open this issue rather than replicating.