search

artemgordinskiy / Spotifree

An OS X app that automatically mutes ads on Spotify [DISCONTINUED]
http://spotifree.gordinskiy.com
MIT License
1.05k stars 70 forks source link

Spotify becomes unmuted for last ~1 second of advertisement #87

Closed tomglynch closed 7 years ago

tomglynch commented 7 years ago

Spotify seems to become unmuted slightly early, leaving the last word or so of the ad unmuted before switching to the next song.

Trosterud commented 7 years ago

Yeah I get the same thing. Looks like this issue (which was fixed before this project was rewritten in Swift. Eliminate tiny duration of ad sound #61 https://github.com/ArtemGordinsky/Spotifree/pull/61/commits/771a725e4fcc5b195894e7026e8a52f5f6c5619b

I guess a smiliar kind of solution would work here. Probably in Spotifree/Spotifree/SpotifyManager.swift around line 67 or 108.

Any idea on how to actually implement it?

michaelsilver commented 7 years ago

Any update on this?

sam-k commented 7 years ago

Issue still exists.

tomglynch commented 7 years ago

Had a look but couldn't work out the cause.

On Mon, Mar 20, 2017 at 1:30 PM, samkim1729 notifications@github.com wrote:

Issue still exists.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/ArtemGordinsky/Spotifree/issues/87#issuecomment-287668400, or mute the thread https://github.com/notifications/unsubscribe-auth/ARDTm91Cf-hW5tcrAYo0x14iiNB23qShks5rneTTgaJpZM4KF1yi .

jaywilliams commented 7 years ago

I downloaded the source code and added a simple one second delay to fix this. You can see my pull request here: #96

The actual code change is quite small: https://github.com/ArtemGordinsky/Spotifree/pull/96/commits/63c4d97682dddc1932d29973b1b3511019d675e4