search

artemgordinskiy / Spotifree

An OS X app that automatically mutes ads on Spotify [DISCONTINUED]
http://spotifree.gordinskiy.com
MIT License
1.05k stars 70 forks source link

Some ads are un-muted about a second early #97

Open ghost opened 7 years ago

ghost commented 7 years ago

I've been noticing that with some ads, they are unmuted for about a second before they end.

CENGOiSM commented 7 years ago

Do you have crossfade enabled? If yes, try again disabling it.

ghost commented 7 years ago

No, I don't have crossfade enabled: Crossfade

completerevolution commented 6 years ago

I have noticed this issue today too, but only a handful of ads. I can't see (well, hear!) a pattern to report back.

jackyliang commented 6 years ago

I noticed this happening as well. Don't have crossfade enabled.

liesislukas commented 6 years ago

crossfade is off. All default settings just downloaded Spotify app and your app. Fresh install and i have this issue too. Not sure if with all ads but most for sure. You could make just not instant volume up, but volume fadeIn while it's the start of the song anyways.

Haven't done anything with swift but this seems would solve the issue:

https://stackoverflow.com/questions/39787319/add-a-delay-to-a-for-loop-in-swift

at

https://github.com/ArtemGordinsky/Spotifree/blob/ead811c2de41bbee1382dd05f8a59d1bca7a7c5d/Spotifree/SpotifyManager.swift#L112

ghost commented 6 years ago

I've tried a clean re-install (I reimaged my Mac a couple days ago) and I still have this issue.

peteringram0 commented 6 years ago

Also getting this on version 1.6.5

chmiiller commented 5 years ago

this is fixed here #96 but I cannot find a release with this PR merged