search

artemis-nerds / protocol-docs

Unofficial documentation for the Artemis network and file protocols, written by the Artemis community
https://artemis-nerds.github.io/protocol-docs/
MIT License
8 stars 5 forks source link

consistency between pc2.3(Hull ID) & npc1.7(Vessel type) #165

Closed StarryWisdom closed 3 years ago

StarryWisdom commented 6 years ago

both of these fields refer to the same thing - logically they should have the same name (another logical name is uniqueID - taken from vessel data)

imo any name just one thats consistent would be nice

NoseyNick commented 6 years ago

Mission scripts call it...

<create type ="enemy" hullID="4001" />

vesselData.xml calls it...

<vessel uniqueID="1000" />

To add to the confusion, my parser.pl calls them PlayerShip.ShipType and NPCShip.VesselType :disappointed: I'll switch to whatever we choose here... and cast one vote for hullID, as it's "official" and not as vague as "uniqueID"

NoseyNick commented 6 years ago

See also Base.VesselType (bit 1.5)

NoseyNick commented 6 years ago

Also AllShipSettingsPacket Ship type (int)

NoseyNick commented 6 years ago

Also SetFighterSettingsPacket Vessel type (int) [yeah I think I'm done for now :stuck_out_tongue_winking_eye: ]

NoseyNick commented 3 years ago

Anyone know of a good way to vote on GitHub? I think my preference would be for hullID, from mission-file-docs.txt The only other "semi-official" one would be uniqueID but that feels potentially confusing in protocol descriptions.