search

artemiscloud / activemq-artemis-operator

Apache License 2.0
66 stars 62 forks source link

Update jolokia.go #926

Open Nanmozhi22 opened 4 months ago

Nanmozhi22 commented 4 months ago

Disabled TLS certificate check

brusdev commented 4 months ago

@Nanmozhi22 can you create an issue at https://github.com/artemiscloud/activemq-artemis-operator/issues/new/choose and add the number of the issue at the beginning of the commit message?

Nanmozhi22 commented 4 months ago

@brusdev Thank you for your response!

But I have already opened an issue https://github.com/artemiscloud/activemq-artemis-operator/issues/919 and committed the code .

Do you still want me to create a new issue and the number of the commit ? It would be great if you can clarify this.

Thanks Nan

brusdev commented 4 months ago

@Nanmozhi22 #919 is fine, you just need to add the number of the issue at the beginning of the commit message, i.e.

[#919] Update jolokia.go
brusdev commented 4 months ago

I'm wondering if this change can break deployment with a console secured by self signed certificates

Nanmozhi22 commented 4 months ago

@brusdev Thank for the update! Do you think this PR can cause any potential issue ?

brusdev commented 4 months ago

@Nanmozhi22 I think this PR is a good security improvement but we need to figure out a solution for deployments with a console secured by self signed certificates

Nanmozhi22 commented 4 months ago

@brusdev got it , Just curious until if we figure out a solution this PR can't be merged ?

brusdev commented 4 months ago

@brusdev got it , Just curious until if we figure out a solution this PR can't be merged ?

@Nanmozhi22 I don't think so, I'll convert it to draft