search

artemiscloud / activemq-artemis-operator

Apache License 2.0
69 stars 63 forks source link

[#968] Replace HTTP test proxy with SSH tunnels #969

Closed brusdev closed 4 months ago

brusdev commented 4 months ago

SSH tunnels support HTTPS and other tcp connections.

gaohoward commented 4 months ago

@brusdev I just found that when 'test' namespace already exists, this line fails:

https://github.com/artemiscloud/activemq-artemis-operator/blob/0babfdc623fc29ce8b721331756ff21b6baf1543/controllers/suite_test.go#L223

I think we should use Expect(err == nil || errors.IsAlreadyExists(err)).To(BeTrue())

brusdev commented 4 months ago

@brusdev I just found that when 'test' namespace already exists, this line fails:

https://github.com/artemiscloud/activemq-artemis-operator/blob/0babfdc623fc29ce8b721331756ff21b6baf1543/controllers/suite_test.go#L223

I think we should use Expect(err == nil || errors.IsAlreadyExists(err)).To(BeTrue())

@gaohoward I have just fixed it